We will do this exercise in pairs.
In this exercise, both partners make a repository on Github and set up code and tests within it. The repository is liked to Travis for automated testing. Both partners find a bug in their repository, make an issue, clone each other’s repos, fixes the bug, makes a pull request, checks the automated tests on Github, and merge their partner’s change.
Here is an overview of this exercise. Below we detail the steps.
On Travis CI:
Clone the repository.
Add a file
def add(a, b): return a + b def test_add(): assert add(2, 3) == 5 assert add('space', 'ship') == 'spaceship' def subtract(a, b): return a + b # <--- fix this in step 8 # uncomment the following test in step 5 #def test_subtract(): # assert subtract(2, 3) == -1
Add a file
.travis.yml (mind the “.” at the beginning) containing:
sudo: false language: - python python: - 2.7 - 3.6 install: - pip install pytest script: - pytest --verbose example.py notifications: email: false
git add the two files, commit, and push the changes to GitHub.
After you have pushed, go to https://travis-ci.org and verify that Travis automatically picked up the change to the repository and ran the tests. It should take less than 1 minute for the test set to run. Also click on one of the python versions on Travis to see the full output.
If you forgot to enable Travis before pushing, you may have to tell Travis to run the test manually.
For this uncomment the code under “step 5”, commit, and push. Verify on Travis that the test suite now fails.
Open a new issue on the broken test on GitHub. The plan is that your exercise partner will fix the issue.
Now you know the drill.
After you have fixed the code,
commit the following commit message
"restore function subtract; fixes #1" (assuming that you try to fix issue number 1).
Once the pull request is accepted/merged, this will autoclose the issue since GitHub will recognize the “fixes #1” in the commit message, see also closing issues using keywords.
Then push to your fork.
And wait for your partner to do the same. Then before accepting the pull request from your partner, observe how Travis automatically tested the code.
Observe how accepting the pull request automatically closes the issue (provided the commit message contained the correct issue number).
Discuss whether this is a useful feature. And if it is, why do you think is it useful?
We discuss together about our experiences with this exercise.
To enable automated testing on Travis, simply enable the repository and add a
When fixing bugs or other problems reported in issues, use the issue autoclosing mechanism when you send the pull request